Skip to content

Commit

Permalink
thermal: intel: intel_pch: Make pch_wpt_add_acpi_psv_trip() return int
Browse files Browse the repository at this point in the history
Modify pch_wpt_add_acpi_psv_trip() to return an int value instead of
using a return pointer for that.

While at it, drop an excessive empty code line.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Tested-by: Zhang Rui <rui.zhang@intel.com>
Reviewed-by: Zhang Rui <rui.zhang@intel.com>
  • Loading branch information
Rafael J. Wysocki committed Feb 2, 2023
1 parent 1bcebca commit 2cee735
Showing 1 changed file with 9 additions and 12 deletions.
21 changes: 9 additions & 12 deletions drivers/thermal/intel/intel_pch_thermal.c
Original file line number Diff line number Diff line change
Expand Up @@ -90,34 +90,31 @@ struct pch_thermal_device {
};

#ifdef CONFIG_ACPI

/*
* On some platforms, there is a companion ACPI device, which adds
* passive trip temperature using _PSV method. There is no specific
* passive temperature setting in MMIO interface of this PCI device.
*/
static void pch_wpt_add_acpi_psv_trip(struct pch_thermal_device *ptd,
int *nr_trips)
static int pch_wpt_add_acpi_psv_trip(struct pch_thermal_device *ptd, int trip)
{
struct acpi_device *adev;
int temp;

adev = ACPI_COMPANION(&ptd->pdev->dev);
if (!adev)
return;
return 0;

if (thermal_acpi_passive_trip_temp(adev, &temp) || temp <= 0)
return;
return 0;

ptd->trips[*nr_trips].type = THERMAL_TRIP_PASSIVE;
ptd->trips[*nr_trips].temperature = temp;
++(*nr_trips);
ptd->trips[trip].type = THERMAL_TRIP_PASSIVE;
ptd->trips[trip].temperature = temp;
return 1;
}
#else
static void pch_wpt_add_acpi_psv_trip(struct pch_thermal_device *ptd,
int *nr_trips)
static int pch_wpt_add_acpi_psv_trip(struct pch_thermal_device *ptd, int trip)
{

return 0;
}
#endif

Expand Down Expand Up @@ -167,7 +164,7 @@ static int pch_wpt_init(struct pch_thermal_device *ptd, int *nr_trips)
++(*nr_trips);
}

pch_wpt_add_acpi_psv_trip(ptd, nr_trips);
*nr_trips += pch_wpt_add_acpi_psv_trip(ptd, *nr_trips);

return 0;
}
Expand Down

0 comments on commit 2cee735

Please sign in to comment.