Skip to content

Commit

Permalink
remoteproc: Remove null character write of shared mem
Browse files Browse the repository at this point in the history
remoteproc is writing '\0' in the shared mem region. This
region is shared among multiple clients that are also trying
to read. Hence they miss first character.

Remove this null character write, as this mem area is
supposed to be Read only.

Further during every subsystem reboot, this region is
initialized with default, hence no need to write this
region.

Signed-off-by: Jitendra Sharma <shajit@codeaurora.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
  • Loading branch information
Jitendra Sharma authored and Bjorn Andersson committed Feb 12, 2018
1 parent 7928b2c commit 2d02d15
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 12 deletions.
3 changes: 0 additions & 3 deletions drivers/remoteproc/qcom_adsp_pil.c
Original file line number Diff line number Diff line change
Expand Up @@ -201,9 +201,6 @@ static irqreturn_t adsp_fatal_interrupt(int irq, void *dev)

rproc_report_crash(adsp->rproc, RPROC_FATAL_ERROR);

if (!IS_ERR(msg))
msg[0] = '\0';

return IRQ_HANDLED;
}

Expand Down
6 changes: 0 additions & 6 deletions drivers/remoteproc/qcom_q6v5_pil.c
Original file line number Diff line number Diff line change
Expand Up @@ -939,9 +939,6 @@ static irqreturn_t q6v5_wdog_interrupt(int irq, void *dev)

rproc_report_crash(qproc->rproc, RPROC_WATCHDOG);

if (!IS_ERR(msg))
msg[0] = '\0';

return IRQ_HANDLED;
}

Expand All @@ -959,9 +956,6 @@ static irqreturn_t q6v5_fatal_interrupt(int irq, void *dev)

rproc_report_crash(qproc->rproc, RPROC_FATAL_ERROR);

if (!IS_ERR(msg))
msg[0] = '\0';

return IRQ_HANDLED;
}

Expand Down
3 changes: 0 additions & 3 deletions drivers/remoteproc/qcom_wcnss.c
Original file line number Diff line number Diff line change
Expand Up @@ -332,9 +332,6 @@ static irqreturn_t wcnss_fatal_interrupt(int irq, void *dev)

rproc_report_crash(wcnss->rproc, RPROC_FATAL_ERROR);

if (!IS_ERR(msg))
msg[0] = '\0';

return IRQ_HANDLED;
}

Expand Down

0 comments on commit 2d02d15

Please sign in to comment.