Skip to content

Commit

Permalink
pinctrl: add some comments to the hog/late init code
Browse files Browse the repository at this point in the history
It confused me a bit so it may confuse others. Make it crystal
clear what is going on here for any future readers.

Cc: Tony Lindgren <tony@atomide.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
  • Loading branch information
Linus Walleij committed Jan 3, 2017
1 parent 99e4f67 commit 2d22e5b
Showing 1 changed file with 12 additions and 0 deletions.
12 changes: 12 additions & 0 deletions drivers/pinctrl/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -1753,6 +1753,12 @@ static void pinctrl_late_init(struct work_struct *work)

pctldev = container_of(work, struct pinctrl_dev, late_init.work);

/*
* If the pin controller does NOT have hogs, this will report an
* error and we skip over this entire branch. This is why we can
* call this function directly when we do not have hogs on the
* device.
*/
pctldev->p = create_pinctrl(pctldev->dev, pctldev);
if (!IS_ERR(pctldev->p)) {
kref_get(&pctldev->p->users);
Expand Down Expand Up @@ -1847,6 +1853,12 @@ struct pinctrl_dev *pinctrl_register(struct pinctrl_desc *pctldesc,
goto out_err;
}

/*
* If the device has hogs we want the probe() function of the driver
* to complete before we go in and hog them and add the pin controller
* to the list of controllers. If it has no hogs, we can just complete
* the registration immediately.
*/
if (pinctrl_dt_has_hogs(pctldev))
schedule_delayed_work(&pctldev->late_init, 0);
else
Expand Down

0 comments on commit 2d22e5b

Please sign in to comment.