Skip to content

Commit

Permalink
arm64: perf: Remove unnecessary printk
Browse files Browse the repository at this point in the history
ARM64 pmu prints an error message in event_init() when
no hardware PMU is available. This is pretty annoying as
it keeps printing the message for every single trial, flooding
the kernel logs, unnecessarily. The return code is sufficient for
the user to figure out the reason.

Signed-off-by: Suzuki K. Poulose <suzuki.poulose@arm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
  • Loading branch information
Suzuki K. Poulose authored and Will Deacon committed Jul 27, 2015
1 parent cbfe8fa commit 2d23ed0
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions arch/arm64/kernel/perf_event.c
Original file line number Diff line number Diff line change
Expand Up @@ -435,10 +435,8 @@ armpmu_reserve_hardware(struct arm_pmu *armpmu)
unsigned int i, irqs;
struct platform_device *pmu_device = armpmu->plat_device;

if (!pmu_device) {
pr_err("no PMU device registered\n");
if (!pmu_device)
return -ENODEV;
}

irqs = min(pmu_device->num_resources, num_possible_cpus());
if (!irqs) {
Expand Down

0 comments on commit 2d23ed0

Please sign in to comment.