Skip to content

Commit

Permalink
efi/fb: Correct PCI_STD_RESOURCE_END usage
Browse files Browse the repository at this point in the history
[ Upstream commit 92a16c8 ]

PCI_STD_RESOURCE_END is (confusingly) the index of the last valid BAR, not
the *number* of BARs.  To iterate through all possible BARs, we need to
include PCI_STD_RESOURCE_END.

Fixes: 55d728a ("efi/fb: Avoid reconfiguration of BAR that covers the framebuffer")
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
Bjorn Helgaas authored and Greg Kroah-Hartman committed Nov 10, 2018
1 parent 08ae439 commit 2d4260b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/video/fbdev/efifb.c
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,7 @@ static void efifb_fixup_resources(struct pci_dev *dev)
if (!base)
return;

for (i = 0; i < PCI_STD_RESOURCE_END; i++) {
for (i = 0; i <= PCI_STD_RESOURCE_END; i++) {
struct resource *res = &dev->resource[i];

if (!(res->flags & IORESOURCE_MEM))
Expand Down

0 comments on commit 2d4260b

Please sign in to comment.