Skip to content

Commit

Permalink
block: xen-blkback: add null check to avoid null pointer dereference
Browse files Browse the repository at this point in the history
Add null check before calling xen_blkif_put() to avoid potential
null pointer dereference.

Addresses-Coverity-ID: 1350942
Cc: Juergen Gross <jgross@suse.com>
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
  • Loading branch information
Gustavo A. R. Silva authored and Konrad Rzeszutek Wilk committed May 15, 2017
1 parent 89515d0 commit 2d4456c
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions drivers/block/xen-blkback/xenbus.c
Original file line number Diff line number Diff line change
Expand Up @@ -504,11 +504,13 @@ static int xen_blkbk_remove(struct xenbus_device *dev)

dev_set_drvdata(&dev->dev, NULL);

if (be->blkif)
if (be->blkif) {
xen_blkif_disconnect(be->blkif);

/* Put the reference we set in xen_blkif_alloc(). */
xen_blkif_put(be->blkif);
/* Put the reference we set in xen_blkif_alloc(). */
xen_blkif_put(be->blkif);
}

kfree(be->mode);
kfree(be);
return 0;
Expand Down

0 comments on commit 2d4456c

Please sign in to comment.