Skip to content

Commit

Permalink
xfs: remove unused parameter from xfs_writepage_map
Browse files Browse the repository at this point in the history
The first thing that xfs_writepage_map does is clobber the offset
parameter.  Since we never use the passed-in value, turn the parameter
into a local variable.  This gets rid of an UBSAN warning in generic/466.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
  • Loading branch information
Darrick J. Wong committed Nov 30, 2017
1 parent 22a6c83 commit 2d5f4b5
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions fs/xfs/xfs_aops.c
Original file line number Diff line number Diff line change
Expand Up @@ -896,13 +896,13 @@ xfs_writepage_map(
struct writeback_control *wbc,
struct inode *inode,
struct page *page,
loff_t offset,
uint64_t end_offset)
uint64_t end_offset)
{
LIST_HEAD(submit_list);
struct xfs_ioend *ioend, *next;
struct buffer_head *bh, *head;
ssize_t len = i_blocksize(inode);
uint64_t offset;
int error = 0;
int count = 0;
int uptodate = 1;
Expand Down Expand Up @@ -1146,7 +1146,7 @@ xfs_do_writepage(
end_offset = offset;
}

return xfs_writepage_map(wpc, wbc, inode, page, offset, end_offset);
return xfs_writepage_map(wpc, wbc, inode, page, end_offset);

redirty:
redirty_page_for_writepage(wbc, page);
Expand Down

0 comments on commit 2d5f4b5

Please sign in to comment.