Skip to content

Commit

Permalink
[IA64] always map VGA framebuffer UC, even if it supports WB
Browse files Browse the repository at this point in the history
EFI on some machines, e.g., Intel Tiger, reports that the VGA framebuffer
supports WB access.  ioremap() prefers WB when possible, so it can work
when mapping main memory.

But it doesn't make sense to map a framebuffer WB, because the driver
doesn't flush explicitly, so updates won't make it to the device
immediately.

This is due to Zou Nan hai <nanhai.zou@intel.com>.

More extensive fix that adds a "size" argument coming soon.

Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: "Antonino A. Daplas" <adaplas@pol.net>
Cc: "Luck, Tony" <tony.luck@intel.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Tony Luck <tony.luck@intel.com>
  • Loading branch information
Bjorn Helgaas authored and Tony Luck committed Apr 8, 2006
1 parent cfab9d0 commit 2db8d99
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion include/asm-ia64/vga.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
extern unsigned long vga_console_iobase;
extern unsigned long vga_console_membase;

#define VGA_MAP_MEM(x) ((unsigned long) ioremap(vga_console_membase + (x), 0))
#define VGA_MAP_MEM(x) ((unsigned long) ioremap_nocache(vga_console_membase + (x), 0))

#define vga_readb(x) (*(x))
#define vga_writeb(x,y) (*(y) = (x))
Expand Down

0 comments on commit 2db8d99

Please sign in to comment.