Skip to content

Commit

Permalink
drm/i915: rip out indirection for pfit pipe_config assignment
Browse files Browse the repository at this point in the history
This was still required a bit (on the cargo-cult side though) when the
state was stored in dev_priv, and when the enable/disable sequence was
botched a bit (to avoid too many updates).

But with pipeconfig we always get a clean slate, so this is pointless.
Rip it out.

Reviewed-by: Mika Kuoppala <mika.kuoppala@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
  • Loading branch information
Daniel Vetter committed Apr 30, 2013
1 parent 68fc874 commit 2deefda
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions drivers/gpu/drm/i915/intel_panel.c
Original file line number Diff line number Diff line change
Expand Up @@ -306,11 +306,8 @@ void intel_gmch_panel_fitting(struct intel_crtc *intel_crtc,
if (INTEL_INFO(dev)->gen < 4 && pipe_config->pipe_bpp == 18)
pfit_control |= PANEL_8TO6_DITHER_ENABLE;

if (pfit_control != pipe_config->gmch_pfit.control ||
pfit_pgm_ratios != pipe_config->gmch_pfit.pgm_ratios) {
pipe_config->gmch_pfit.control = pfit_control;
pipe_config->gmch_pfit.pgm_ratios = pfit_pgm_ratios;
}
pipe_config->gmch_pfit.control = pfit_control;
pipe_config->gmch_pfit.pgm_ratios = pfit_pgm_ratios;
pipe_config->gmch_pfit.lvds_border_bits = border;
}

Expand Down

0 comments on commit 2deefda

Please sign in to comment.