Skip to content

Commit

Permalink
Revert "isci: fix reset timeout handling"
Browse files Browse the repository at this point in the history
This reverts commit 584ec12, which
was commit ddfadd7 upstream.  It
causes boot failure on 3.2 although no such problem occurs upstream.

Reported-by: Ondrej Zary <linux@rainbow-software.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Acked-by: Dan Williams <dan.j.williams@intel.com>
  • Loading branch information
Ben Hutchings committed Apr 30, 2014
1 parent 5311955 commit 2e59f01
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
7 changes: 7 additions & 0 deletions drivers/scsi/isci/port_config.c
Original file line number Diff line number Diff line change
Expand Up @@ -610,6 +610,13 @@ static void sci_apc_agent_link_up(struct isci_host *ihost,
sci_apc_agent_configure_ports(ihost, port_agent, iphy, true);
} else {
/* the phy is already the part of the port */
u32 port_state = iport->sm.current_state_id;

/* if the PORT'S state is resetting then the link up is from
* port hard reset in this case, we need to tell the port
* that link up is recieved
*/
BUG_ON(port_state != SCI_PORT_RESETTING);
port_agent->phy_ready_mask |= 1 << phy_index;
sci_port_link_up(iport, iphy);
}
Expand Down
2 changes: 1 addition & 1 deletion drivers/scsi/isci/task.c
Original file line number Diff line number Diff line change
Expand Up @@ -1390,7 +1390,7 @@ int isci_task_I_T_nexus_reset(struct domain_device *dev)
spin_unlock_irqrestore(&ihost->scic_lock, flags);

if (!idev || !test_bit(IDEV_EH, &idev->flags)) {
ret = -ENODEV;
ret = TMF_RESP_FUNC_COMPLETE;
goto out;
}

Expand Down

0 comments on commit 2e59f01

Please sign in to comment.