Skip to content

Commit

Permalink
nfp: bpf: byte swap the instructions
Browse files Browse the repository at this point in the history
Device expects the instructions in little endian.  Make sure we
byte swap on big endian hosts.

Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: Simon Horman <simon.horman@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Jakub Kicinski authored and David S. Miller committed Oct 9, 2017
1 parent 1c03e03 commit 2e85d38
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions drivers/net/ethernet/netronome/nfp/bpf/jit.c
Original file line number Diff line number Diff line change
Expand Up @@ -1725,7 +1725,7 @@ static int nfp_bpf_optimize(struct nfp_prog *nfp_prog)
return 0;
}

static int nfp_bpf_ustore_calc(struct nfp_prog *nfp_prog)
static int nfp_bpf_ustore_calc(struct nfp_prog *nfp_prog, __le64 *ustore)
{
int i;

Expand All @@ -1737,6 +1737,8 @@ static int nfp_bpf_ustore_calc(struct nfp_prog *nfp_prog)
return err;

nfp_prog->prog[i] = nfp_ustore_calc_ecc_insn(nfp_prog->prog[i]);

ustore[i] = cpu_to_le64(nfp_prog->prog[i]);
}

return 0;
Expand Down Expand Up @@ -1796,7 +1798,7 @@ nfp_bpf_jit(struct bpf_prog *filter, void *prog_mem,
goto out;
}

ret = nfp_bpf_ustore_calc(nfp_prog);
ret = nfp_bpf_ustore_calc(nfp_prog, (__force __le64 *)prog_mem);

res->n_instr = nfp_prog->prog_len;
res->dense_mode = false;
Expand Down

0 comments on commit 2e85d38

Please sign in to comment.