Skip to content

Commit

Permalink
drm/i915/selftests: Convert timers to use timer_setup()
Browse files Browse the repository at this point in the history
In preparation for unconditionally passing the struct timer_list pointer to
all timer callbacks, switch to using the new timer_setup() and from_timer()
to pass the timer pointer explicitly.

Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Kees Cook <keescook@chromium.org>
Acked-by: Jani Nikula <jani.nikula@intel.com>
  • Loading branch information
Kees Cook committed Nov 21, 2017
1 parent 72a9f9a commit 2ea5b4d
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions drivers/gpu/drm/i915/selftests/lib_sw_fence.c
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,9 @@ void onstack_fence_fini(struct i915_sw_fence *fence)
i915_sw_fence_fini(fence);
}

static void timed_fence_wake(unsigned long data)
static void timed_fence_wake(struct timer_list *t)
{
struct timed_fence *tf = (struct timed_fence *)data;
struct timed_fence *tf = from_timer(tf, t, timer);

i915_sw_fence_commit(&tf->fence);
}
Expand All @@ -60,7 +60,7 @@ void timed_fence_init(struct timed_fence *tf, unsigned long expires)
{
onstack_fence_init(&tf->fence);

setup_timer_on_stack(&tf->timer, timed_fence_wake, (unsigned long)tf);
timer_setup_on_stack(&tf->timer, timed_fence_wake, 0);

if (time_after(expires, jiffies))
mod_timer(&tf->timer, expires);
Expand Down

0 comments on commit 2ea5b4d

Please sign in to comment.