Skip to content

Commit

Permalink
usb: musb: dsps: Fix vbus vs tps65217-charger irq conflict
Browse files Browse the repository at this point in the history
Enabling the tps65217-charger driver/module causes an interrupt conflict
with the vbus driver resulting in a probe failure.
The conflict is resolved by changing both driver's threaded interrupt
request function from IRQF_ONESHOT to IRQF_SHARED.

Signed-off-by: Grant B Adams <nemith592@gmail.com>
Reviewed-by: Tony Lindgren <tony@atomide.com>
Link: https://lore.kernel.org/r/20230823085430.6610-3-nemith592@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Grant B Adams authored and Greg Kroah-Hartman committed Oct 2, 2023
1 parent ea17be9 commit 2f07592
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/usb/musb/musb_dsps.c
Original file line number Diff line number Diff line change
Expand Up @@ -849,7 +849,7 @@ static int dsps_setup_optional_vbus_irq(struct platform_device *pdev,

error = devm_request_threaded_irq(glue->dev, glue->vbus_irq,
NULL, dsps_vbus_threaded_irq,
IRQF_ONESHOT,
IRQF_SHARED,
"vbus", glue);
if (error) {
glue->vbus_irq = 0;
Expand Down

0 comments on commit 2f07592

Please sign in to comment.