Skip to content

Commit

Permalink
of: device: Kill of_device_request_module()
Browse files Browse the repository at this point in the history
A new helper has been introduced, of_request_module(). Users have been
converted, this helper can now be deleted.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Reviewed-by: Rob Herring <robh@kernel.org>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20230404172148.82422-13-srinivas.kandagatla@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Miquel Raynal authored and Greg Kroah-Hartman committed Apr 5, 2023
1 parent 1969753 commit 2f555f5
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 15 deletions.
9 changes: 0 additions & 9 deletions drivers/of/device.c
Original file line number Diff line number Diff line change
Expand Up @@ -246,15 +246,6 @@ const void *of_device_get_match_data(const struct device *dev)
}
EXPORT_SYMBOL(of_device_get_match_data);

int of_device_request_module(struct device *dev)
{
if (!dev)
return -ENODEV;

return of_request_module(dev->of_node);
}
EXPORT_SYMBOL_GPL(of_device_request_module);

/**
* of_device_modalias - Fill buffer with newline terminated modalias string
* @dev: Calling device
Expand Down
6 changes: 0 additions & 6 deletions include/linux/of_device.h
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ extern void of_device_unregister(struct platform_device *ofdev);
extern const void *of_device_get_match_data(const struct device *dev);

extern ssize_t of_device_modalias(struct device *dev, char *str, ssize_t len);
extern int of_device_request_module(struct device *dev);

extern void of_device_uevent(const struct device *dev, struct kobj_uevent_env *env);
extern int of_device_uevent_modalias(const struct device *dev, struct kobj_uevent_env *env);
Expand Down Expand Up @@ -78,11 +77,6 @@ static inline int of_device_modalias(struct device *dev,
return -ENODEV;
}

static inline int of_device_request_module(struct device *dev)
{
return -ENODEV;
}

static inline int of_device_uevent_modalias(const struct device *dev,
struct kobj_uevent_env *env)
{
Expand Down

0 comments on commit 2f555f5

Please sign in to comment.