Skip to content

Commit

Permalink
scsi: qla2xxx: Fix memory leak when sending I/O fails
Browse files Browse the repository at this point in the history
On heavy loads, a memory leak of the srb_t structure is observed.  This
would make the qla2xxx_srbs cache gobble up memory.

Fixes: 219d27d ("scsi: qla2xxx: Fix race conditions in the code for aborting SCSI commands")
Cc: stable@vger.kernel.org # 5.2
Link: https://lore.kernel.org/r/20191105150657.8092-7-hmadhani@marvell.com
Reviewed-by: Ewan D. Milne <emilne@redhat.com>
Signed-off-by: Arun Easi <aeasi@marvell.com>
Signed-off-by: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
  • Loading branch information
Arun Easi authored and Martin K. Petersen committed Nov 9, 2019
1 parent f45bca8 commit 2f856d4
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions drivers/scsi/qla2xxx/qla_os.c
Original file line number Diff line number Diff line change
Expand Up @@ -909,6 +909,8 @@ qla2xxx_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *cmd)

qc24_host_busy_free_sp:
sp->free(sp);
CMD_SP(cmd) = NULL;
qla2x00_rel_sp(sp);

qc24_target_busy:
return SCSI_MLQUEUE_TARGET_BUSY;
Expand Down Expand Up @@ -992,6 +994,8 @@ qla2xxx_mqueuecommand(struct Scsi_Host *host, struct scsi_cmnd *cmd,

qc24_host_busy_free_sp:
sp->free(sp);
CMD_SP(cmd) = NULL;
qla2xxx_rel_qpair_sp(sp->qpair, sp);

qc24_target_busy:
return SCSI_MLQUEUE_TARGET_BUSY;
Expand Down

0 comments on commit 2f856d4

Please sign in to comment.