Skip to content

Commit

Permalink
mfd: dln2: A couple endian fixes
Browse files Browse the repository at this point in the history
Sparse catches a couple endian bugs.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Octavian Purdila <octavian.purdila@intel.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
  • Loading branch information
Dan Carpenter authored and Lee Jones committed Nov 19, 2014
1 parent 00ee7a3 commit 2fc2b48
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions drivers/mfd/dln2.c
Original file line number Diff line number Diff line change
Expand Up @@ -436,6 +436,7 @@ static int _dln2_transfer(struct dln2_dev *dln2, u16 handle, u16 cmd,
struct device *dev = &dln2->interface->dev;
const unsigned long timeout = DLN2_USB_TIMEOUT * HZ / 1000;
struct dln2_mod_rx_slots *rxs = &dln2->mod_rx_slots[handle];
int size;

spin_lock(&dln2->disconnect_lock);
if (!dln2->disconnect)
Expand Down Expand Up @@ -477,8 +478,9 @@ static int _dln2_transfer(struct dln2_dev *dln2, u16 handle, u16 cmd,

/* if we got here we know that the response header has been checked */
rsp = rxc->urb->transfer_buffer;
size = le16_to_cpu(rsp->hdr.size);

if (rsp->hdr.size < sizeof(*rsp)) {
if (size < sizeof(*rsp)) {
ret = -EPROTO;
goto out_free_rx_slot;
}
Expand All @@ -493,8 +495,8 @@ static int _dln2_transfer(struct dln2_dev *dln2, u16 handle, u16 cmd,
if (!ibuf)
goto out_free_rx_slot;

if (*ibuf_len > rsp->hdr.size - sizeof(*rsp))
*ibuf_len = rsp->hdr.size - sizeof(*rsp);
if (*ibuf_len > size - sizeof(*rsp))
*ibuf_len = size - sizeof(*rsp);

memcpy(ibuf, rsp + 1, *ibuf_len);

Expand Down

0 comments on commit 2fc2b48

Please sign in to comment.