Skip to content

Commit

Permalink
USB: keyspan: Fix oops
Browse files Browse the repository at this point in the history
If we get a data URB back from the hardware after we have put the tty to
bed we go kaboom. Fortunately all we need to do is process the URB
without trying to ram its contents down the throat of an ex-tty.

Cc: stable <stable@kernel.org>
Signed-off-by: Alan Cox <alan@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Alan Cox authored and Greg Kroah-Hartman committed Feb 1, 2008
1 parent 24e1c13 commit 3004e53
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/usb/serial/keyspan.c
Original file line number Diff line number Diff line change
Expand Up @@ -838,7 +838,7 @@ static void usa49_indat_callback(struct urb *urb)

port = (struct usb_serial_port *) urb->context;
tty = port->tty;
if (urb->actual_length) {
if (tty && urb->actual_length) {
/* 0x80 bit is error flag */
if ((data[0] & 0x80) == 0) {
/* no error on any byte */
Expand Down

0 comments on commit 3004e53

Please sign in to comment.