Skip to content

Commit

Permalink
usb: musb: omap: fix crash when musb glue (omap) gets initialized
Browse files Browse the repository at this point in the history
pm_runtime_enable is being called after omap2430_musb_init. Hence
pm_runtime_get_sync in omap2430_musb_init does not have any effect (does
not enable clocks) resulting in a crash during register access. It is
fixed here.

Cc: stable@vger.kernel.org # v3.0, v3.1, v3.2, v3.3
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
  • Loading branch information
Kishon Vijay Abraham I authored and Felipe Balbi committed Apr 10, 2012
1 parent bf070bc commit 3006dc8
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/usb/musb/omap2430.c
Original file line number Diff line number Diff line change
Expand Up @@ -453,14 +453,14 @@ static int __devinit omap2430_probe(struct platform_device *pdev)
goto err2;
}

pm_runtime_enable(&pdev->dev);

ret = platform_device_add(musb);
if (ret) {
dev_err(&pdev->dev, "failed to register musb device\n");
goto err2;
}

pm_runtime_enable(&pdev->dev);

return 0;

err2:
Expand Down

0 comments on commit 3006dc8

Please sign in to comment.