Skip to content

Commit

Permalink
drm/panel: novatek-nt36672e: stop setting register load before disable
Browse files Browse the repository at this point in the history
It is pointless to set register load before disabling the register. This
vote is going to be dropped as soon as the register is disabled. Drop
these register_set_load calls.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://lore.kernel.org/r/20240404-drop-panel-unregister-v1-3-9f56953c5fb9@linaro.org
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240404-drop-panel-unregister-v1-3-9f56953c5fb9@linaro.org
  • Loading branch information
Dmitry Baryshkov authored and Neil Armstrong committed Apr 24, 2024
1 parent 6abe93b commit 302aeb9
Showing 1 changed file with 0 additions and 17 deletions.
17 changes: 0 additions & 17 deletions drivers/gpu/drm/panel/panel-novatek-nt36672e.c
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,6 @@ static const unsigned long regulator_enable_loads[] = {
100000,
};

static const unsigned long regulator_disable_loads[] = {
80,
100,
100,
};

struct panel_desc {
const struct drm_display_mode *display_mode;
u32 width_mm;
Expand Down Expand Up @@ -385,20 +379,9 @@ static int nt36672e_power_off(struct nt36672e_panel *ctx)
{
struct mipi_dsi_device *dsi = ctx->dsi;
int ret = 0;
int i;

gpiod_set_value(ctx->reset_gpio, 0);

for (i = 0; i < ARRAY_SIZE(ctx->supplies); i++) {
ret = regulator_set_load(ctx->supplies[i].consumer,
regulator_disable_loads[i]);
if (ret) {
dev_err(&dsi->dev, "regulator set load failed for supply %s: %d\n",
ctx->supplies[i].supply, ret);
return ret;
}
}

ret = regulator_bulk_disable(ARRAY_SIZE(ctx->supplies), ctx->supplies);
if (ret)
dev_err(&dsi->dev, "regulator bulk disable failed: %d\n", ret);
Expand Down

0 comments on commit 302aeb9

Please sign in to comment.