Skip to content

Commit

Permalink
Revert "serial: sunhv: Initialize lock for non-registered console"
Browse files Browse the repository at this point in the history
This reverts commit 0f87aa6.

There has been a quick fix against uninitialised lock revealed by
the commit f743061 ("serial: core: Initialise spin lock before use
in uart_configure_port()"). Since we have now better fix in serial core,
this may be safely reverted.

Fixes: 0f87aa6 ("serial: sunhv: Initialize lock for non-registered console")
Depends-on: f743061 ("serial: core: Initialise spin lock before use in uart_configure_port()")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20200711135346.71171-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Andy Shevchenko authored and Greg Kroah-Hartman committed Jul 21, 2020
1 parent 6f2c659 commit 30336ef
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions drivers/tty/serial/sunhv.c
Original file line number Diff line number Diff line change
Expand Up @@ -567,9 +567,6 @@ static int hv_probe(struct platform_device *op)
sunserial_console_match(&sunhv_console, op->dev.of_node,
&sunhv_reg, port->line, false);

/* We need to initialize lock even for non-registered console */
spin_lock_init(&port->lock);

err = uart_add_one_port(&sunhv_reg, port);
if (err)
goto out_unregister_driver;
Expand Down

0 comments on commit 30336ef

Please sign in to comment.