Skip to content

Commit

Permalink
[SCSI] megaraid_sas: fix EH locking
Browse files Browse the repository at this point in the history
recent kernels call the eh_ methods without the host lock held.
megaraid_sas doesn't need it but drops it before calling a sleeping
routine and reqcquires it afterwards.  Just remove the
spin_unlock/spin_lock calls.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
  • Loading branch information
Christoph Hellwig authored and James Bottomley committed Nov 6, 2005
1 parent 7dfdc9a commit 3072c4a
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions drivers/scsi/megaraid/megaraid_sas.c
Original file line number Diff line number Diff line change
Expand Up @@ -767,17 +767,12 @@ static int megasas_generic_reset(struct scsi_cmnd *scmd)
return FAILED;
}

spin_unlock(scmd->device->host->host_lock);

ret_val = megasas_wait_for_outstanding(instance);

if (ret_val == SUCCESS)
printk(KERN_NOTICE "megasas: reset successful \n");
else
printk(KERN_ERR "megasas: failed to do reset\n");

spin_lock(scmd->device->host->host_lock);

return ret_val;
}

Expand Down

0 comments on commit 3072c4a

Please sign in to comment.