Skip to content

Commit

Permalink
ALSA: seq: fix passing wrong pointer in function call of compatibilit…
Browse files Browse the repository at this point in the history
…y layer

This commit is a fix for Linux 4.9-rc1.

In former commit, a function call of compatibility layer for ALSA sequencer
core was obsoleted by an alternative. Although, the alternative gets a
pointer to kernel stack due to mis-programming. As a result, ALSA sequencer
core unexpectedly refers over kernel stack.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: 8ce8eb6 ("ALSA: seq: add an alternative way to handle ioctl requests")
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
  • Loading branch information
Takashi Sakamoto authored and Takashi Iwai committed Oct 12, 2016
1 parent 4875a5f commit 30c0702
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sound/core/seq/seq_compat.c
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ static int snd_seq_call_port_info_ioctl(struct snd_seq_client *client, unsigned
goto error;
data->kernel = NULL;

err = snd_seq_kernel_client_ctl(client->number, cmd, &data);
err = snd_seq_kernel_client_ctl(client->number, cmd, data);
if (err < 0)
goto error;

Expand Down

0 comments on commit 30c0702

Please sign in to comment.