Skip to content

Commit

Permalink
tulip: remove redundant D0 power state set
Browse files Browse the repository at this point in the history
pci_enable_device() will set device power state to D0,
so it's no need to do it again in tulip_init_one().

Signed-off-by: Yijing Wang <wangyijing@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Yijing Wang authored and David S. Miller committed May 31, 2013
1 parent e4afed3 commit 311503b
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions drivers/net/ethernet/dec/tulip/tulip_core.c
Original file line number Diff line number Diff line change
Expand Up @@ -1410,12 +1410,6 @@ static int tulip_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
return i;
}

/* The chip will fail to enter a low-power state later unless
* first explicitly commanded into D0 */
if (pci_set_power_state(pdev, PCI_D0)) {
pr_notice("Failed to set power state to D0\n");
}

irq = pdev->irq;

/* alloc_etherdev ensures aligned and zeroed private structures */
Expand Down

0 comments on commit 311503b

Please sign in to comment.