Skip to content

Commit

Permalink
nvme: tcp: remove redundant assignment to variable ret
Browse files Browse the repository at this point in the history
The variable ret is being initialized with a value that is never read
and is being re-assigned immediately afterwards. The assignment is
redundant and hence can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Max Gurtovoy <maxg@mellanox.com>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
  • Loading branch information
Colin Ian King authored and Sagi Grimberg committed Sep 12, 2019
1 parent 03894b7 commit 312910f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/nvme/host/tcp.c
Original file line number Diff line number Diff line change
@@ -1824,7 +1824,7 @@ static void nvme_tcp_reconnect_or_remove(struct nvme_ctrl *ctrl)
static int nvme_tcp_setup_ctrl(struct nvme_ctrl *ctrl, bool new)
{
struct nvmf_ctrl_options *opts = ctrl->opts;
int ret = -EINVAL;
int ret;

ret = nvme_tcp_configure_admin_queue(ctrl, new);
if (ret)

0 comments on commit 312910f

Please sign in to comment.