Skip to content

Commit

Permalink
drm/amd/display: change kzalloc to kcalloc in dml1_validate()
Browse files Browse the repository at this point in the history
We are trying to get rid of all multiplications from allocation
functions to prevent integer overflows. Here the multiplication is
probably safe, but using kcalloc() is more appropriate and improves
readability. This patch has no effect on runtime behavior.

Reviewed-by: Rodrigo Siqueira <siqueira@igalia.com>
Reviewed-by: Alex Hung <alex.hung@amd.com>
Signed-off-by: Ethan Carter Edwards <ethan@ethancedwards.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
  • Loading branch information
Ethan Carter Edwards authored and Alex Deucher committed Mar 10, 2025
1 parent b17a94f commit 315ce6c
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -1749,7 +1749,8 @@ static bool dml1_validate(struct dc *dc, struct dc_state *context, bool fast_val

int vlevel = 0;
int pipe_cnt = 0;
display_e2e_pipe_params_st *pipes = kzalloc(dc->res_pool->pipe_count * sizeof(display_e2e_pipe_params_st), GFP_KERNEL);
display_e2e_pipe_params_st *pipes = kcalloc(dc->res_pool->pipe_count,
sizeof(display_e2e_pipe_params_st), GFP_KERNEL);

/* To handle Freesync properly, setting FreeSync DML parameters
* to its default state for the first stage of validation
Expand Down

0 comments on commit 315ce6c

Please sign in to comment.