Skip to content

Commit

Permalink
drm/amdgpu/vcn5.0.1: use generic set_power_gating_state helper
Browse files Browse the repository at this point in the history
No need for an IP specific version.

Reviewed-by: Boyuan Zhang <Boyuan.Zhang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
  • Loading branch information
Alex Deucher committed Feb 27, 2025
1 parent 9b648fa commit 31a37df
Showing 1 changed file with 1 addition and 26 deletions.
27 changes: 1 addition & 26 deletions drivers/gpu/drm/amd/amdgpu/vcn_v5_0_1.c
Original file line number Diff line number Diff line change
@@ -42,8 +42,6 @@ static void vcn_v5_0_1_set_unified_ring_funcs(struct amdgpu_device *adev);
static void vcn_v5_0_1_set_irq_funcs(struct amdgpu_device *adev);
static int vcn_v5_0_1_set_pg_state(struct amdgpu_vcn_inst *vinst,
enum amd_powergating_state state);
static int vcn_v5_0_1_set_powergating_state(struct amdgpu_ip_block *ip_block,
enum amd_powergating_state state);
static void vcn_v5_0_1_unified_ring_set_wptr(struct amdgpu_ring *ring);

/**
@@ -1041,29 +1039,6 @@ static int vcn_v5_0_1_set_pg_state(struct amdgpu_vcn_inst *vinst,
return ret;
}

/**
* vcn_v5_0_1_set_powergating_state - set VCN block powergating state
*
* @ip_block: Pointer to the amdgpu_ip_block for this hw instance.
* @state: power gating state
*
* Set VCN block powergating state
*/
static int vcn_v5_0_1_set_powergating_state(struct amdgpu_ip_block *ip_block,
enum amd_powergating_state state)
{
struct amdgpu_device *adev = ip_block->adev;
int ret = 0, i;

for (i = 0; i < adev->vcn.num_vcn_inst; ++i) {
struct amdgpu_vcn_inst *vinst = &adev->vcn.inst[i];

ret |= vinst->set_pg_state(vinst, state);
}

return ret;
}

/**
* vcn_v5_0_1_process_interrupt - process VCN block interrupt
*
@@ -1142,7 +1117,7 @@ static const struct amd_ip_funcs vcn_v5_0_1_ip_funcs = {
.soft_reset = NULL,
.post_soft_reset = NULL,
.set_clockgating_state = vcn_v5_0_1_set_clockgating_state,
.set_powergating_state = vcn_v5_0_1_set_powergating_state,
.set_powergating_state = vcn_set_powergating_state,
.dump_ip_state = vcn_v5_0_0_dump_ip_state,
.print_ip_state = vcn_v5_0_0_print_ip_state,
};

0 comments on commit 31a37df

Please sign in to comment.