Skip to content

Commit

Permalink
net: sched: fw: don't set arg->stop in fw_walk() when empty
Browse files Browse the repository at this point in the history
Some classifiers set arg->stop in their implementation of tp->walk() API
when empty. Most of classifiers do not adhere to that convention. Do not
set arg->stop in fw_walk() to unify tp->walk() behavior among classifier
implementations.

Fixes: ed76f5e ("net: sched: protect filter_chain list with filter_chain_lock mutex")
Signed-off-by: Vlad Buslov <vladbu@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Vlad Buslov authored and David S. Miller committed Feb 17, 2019
1 parent 1eb0016 commit 31a9984
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions net/sched/cls_fw.c
Original file line number Diff line number Diff line change
Expand Up @@ -362,10 +362,7 @@ static void fw_walk(struct tcf_proto *tp, struct tcf_walker *arg,
struct fw_head *head = rtnl_dereference(tp->root);
int h;

if (head == NULL)
arg->stop = 1;

if (arg->stop)
if (head == NULL || arg->stop)
return;

for (h = 0; h < HTSIZE; h++) {
Expand Down

0 comments on commit 31a9984

Please sign in to comment.