Skip to content

Commit

Permalink
[media] s5p-fimc: Use switch statement for better readability
Browse files Browse the repository at this point in the history
Use switch statement rather than multiple 'else if'.

Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Sylwester Nawrocki authored and Mauro Carvalho Chehab committed Jul 30, 2012
1 parent a516d08 commit 31ce54f
Showing 1 changed file with 8 additions and 6 deletions.
14 changes: 8 additions & 6 deletions drivers/media/video/s5p-fimc/fimc-reg.c
Original file line number Diff line number Diff line change
Expand Up @@ -667,7 +667,8 @@ int fimc_hw_set_camera_type(struct fimc_dev *fimc,
FIMC_REG_CIGCTRL_SELCAM_MIPI | FIMC_REG_CIGCTRL_CAMIF_SELWB |
FIMC_REG_CIGCTRL_SELCAM_MIPI_A | FIMC_REG_CIGCTRL_CAM_JPEG);

if (cam->bus_type == FIMC_MIPI_CSI2) {
switch (cam->bus_type) {
case FIMC_MIPI_CSI2:
cfg |= FIMC_REG_CIGCTRL_SELCAM_MIPI;

if (cam->mux_id == 0)
Expand All @@ -691,14 +692,15 @@ int fimc_hw_set_camera_type(struct fimc_dev *fimc,
tmp |= (csis_data_alignment == 32) << 8;

writel(tmp, fimc->regs + FIMC_REG_CSIIMGFMT);

} else if (cam->bus_type == FIMC_ITU_601 ||
cam->bus_type == FIMC_ITU_656) {
break;
case FIMC_ITU_601...FIMC_ITU_656:
if (cam->mux_id == 0) /* ITU-A, ITU-B: 0, 1 */
cfg |= FIMC_REG_CIGCTRL_SELCAM_ITU_A;
} else if (cam->bus_type == FIMC_LCD_WB) {
break;
case FIMC_LCD_WB:
cfg |= FIMC_REG_CIGCTRL_CAMIF_SELWB;
} else {
break;
default:
v4l2_err(vid_cap->vfd, "Invalid camera bus type selected\n");
return -EINVAL;
}
Expand Down

0 comments on commit 31ce54f

Please sign in to comment.