Skip to content

Commit

Permalink
staging: vchiq_core: Drop vchiq_pagelist.h
Browse files Browse the repository at this point in the history
vchiq_pagelist.h only defines one struct and a couple of macros.
It can be merged with vchiq_core since all the pagelist related
function helpers are now in vchiq_core for bulk transfers.

Move the struct and related macros to vchiq_core header and drop
vchiq_pagelist.h.

Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/20240919142130.1331495-4-umang.jain@ideasonboard.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Umang Jain authored and Greg Kroah-Hartman committed Oct 9, 2024
1 parent 72d092f commit 31d2ad6
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 22 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,10 @@
#define MAKE_REMOTE_USE (VCHIQ_MSG_REMOTE_USE << TYPE_SHIFT)
#define MAKE_REMOTE_USE_ACTIVE (VCHIQ_MSG_REMOTE_USE_ACTIVE << TYPE_SHIFT)

#define PAGELIST_WRITE 0
#define PAGELIST_READ 1
#define PAGELIST_READ_WITH_FRAGMENTS 2

#define BELL2 0x08

/* Ensure the fields are wide enough */
Expand Down
11 changes: 10 additions & 1 deletion drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@

#include "../../include/linux/raspberrypi/vchiq.h"
#include "vchiq_cfg.h"
#include "vchiq_pagelist.h"

/* Do this so that we can test-build the code on non-rpi systems */
#if IS_ENABLED(CONFIG_RASPBERRYPI_FIRMWARE)
Expand Down Expand Up @@ -411,6 +410,16 @@ struct vchiq_state {
struct opaque_platform_state *platform_state;
};

struct pagelist {
u32 length;
u16 type;
u16 offset;
u32 addrs[1]; /* N.B. 12 LSBs hold the number
* of following pages at consecutive
* addresses.
*/
};

struct vchiq_pagelist_info {
struct pagelist *pagelist;
size_t pagelist_buffer_size;
Expand Down
21 changes: 0 additions & 21 deletions drivers/staging/vc04_services/interface/vchiq_arm/vchiq_pagelist.h

This file was deleted.

0 comments on commit 31d2ad6

Please sign in to comment.