Skip to content

Commit

Permalink
ipv4: fix rcu lock imbalance in fib_select_default()
Browse files Browse the repository at this point in the history
Commit 0c838ff (ipv4: Consolidate all default route selection
implementations.) forgot to remove one rcu_read_unlock() from
fib_select_default().

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Eric Dumazet authored and David S. Miller committed Feb 14, 2011
1 parent 881ff67 commit 31d4093
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/ipv4/fib_semantics.c
Original file line number Diff line number Diff line change
Expand Up @@ -1189,7 +1189,7 @@ void fib_select_default(struct fib_result *res)
fib_result_assign(res, last_resort);
tb->tb_default = last_idx;
out:
rcu_read_unlock();
return;
}

#ifdef CONFIG_IP_ROUTE_MULTIPATH
Expand Down

0 comments on commit 31d4093

Please sign in to comment.