Skip to content

Commit

Permalink
staging: pi433: fix CamelCase for bitRate variables
Browse files Browse the repository at this point in the history
Fixes checkpatch warnings:

  CHECK: Avoid CamelCase: <bitRate>
  CHECK: Avoid CamelCase: <bitRate_min>
  CHECK: Avoid CamelCase: <bitRate_reg>

Signed-off-by: Valentin Vidic <Valentin.Vidic@CARNet.hr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Valentin Vidic authored and Greg Kroah-Hartman committed Mar 19, 2018
1 parent 8030589 commit 31e045a
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
16 changes: 8 additions & 8 deletions drivers/staging/pi433/rf69.c
Original file line number Diff line number Diff line change
Expand Up @@ -201,26 +201,26 @@ int rf69_set_modulation_shaping(struct spi_device *spi,
}
}

int rf69_set_bit_rate(struct spi_device *spi, u16 bitRate)
int rf69_set_bit_rate(struct spi_device *spi, u16 bit_rate)
{
int retval;
u32 bitRate_min;
u32 bitRate_reg;
u32 bit_rate_min;
u32 bit_rate_reg;
u8 msb;
u8 lsb;

// check input value
bitRate_min = F_OSC / 8388608; // 8388608 = 2^23;
if (bitRate < bitRate_min) {
bit_rate_min = F_OSC / 8388608; // 8388608 = 2^23;
if (bit_rate < bit_rate_min) {
dev_dbg(&spi->dev, "setBitRate: illegal input param");
return -EINVAL;
}

// calculate reg settings
bitRate_reg = (F_OSC / bitRate);
bit_rate_reg = (F_OSC / bit_rate);

msb = (bitRate_reg & 0xff00) >> 8;
lsb = (bitRate_reg & 0xff);
msb = (bit_rate_reg & 0xff00) >> 8;
lsb = (bit_rate_reg & 0xff);

// transmit to RF 69
retval = rf69_write_reg(spi, REG_BITRATE_MSB, msb);
Expand Down
2 changes: 1 addition & 1 deletion drivers/staging/pi433/rf69.h
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ int rf69_set_mode(struct spi_device *spi, enum mode mode);
int rf69_set_data_mode(struct spi_device *spi, u8 data_mode);
int rf69_set_modulation(struct spi_device *spi, enum modulation modulation);
int rf69_set_modulation_shaping(struct spi_device *spi, enum mod_shaping mod_shaping);
int rf69_set_bit_rate(struct spi_device *spi, u16 bitRate);
int rf69_set_bit_rate(struct spi_device *spi, u16 bit_rate);
int rf69_set_deviation(struct spi_device *spi, u32 deviation);
int rf69_set_frequency(struct spi_device *spi, u32 frequency);
int rf69_enable_amplifier(struct spi_device *spi, u8 amplifier_mask);
Expand Down

0 comments on commit 31e045a

Please sign in to comment.