Skip to content

Commit

Permalink
video: fix composite video connector compatible string
Browse files Browse the repository at this point in the history
The quite-recently-added analog-tv-connector bindings say that the
compatible string for composite video connector is
"composite-connector". That string is also used in the omap3-n900.dts
file. However, the connector driver uses "composite-video-connector", so
this has never worked.

While changing the driver's compatible string to "composite-connector"
would be safer, as published DT bindings should not be changed, I'd
rather fix the bindings in this case for two reasons:

* composite-connector is a bit too generic name, as it doesn't even hint
  at video.
* it's clear that this has never worked, which means no one has used
  those bindings, which should make it safe to change this.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
  • Loading branch information
Tomi Valkeinen committed Sep 3, 2014
1 parent 69e273c commit 32797b3
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Analog TV Connector
===================

Required properties:
- compatible: "composite-connector" or "svideo-connector"
- compatible: "composite-video-connector" or "svideo-connector"

Optional properties:
- label: a symbolic name for the connector
Expand All @@ -14,7 +14,7 @@ Example
-------

tv: connector {
compatible = "composite-connector";
compatible = "composite-video-connector";
label = "tv";

port {
Expand Down
2 changes: 1 addition & 1 deletion arch/arm/boot/dts/omap3-n900.dts
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@
};

tv: connector {
compatible = "composite-connector";
compatible = "composite-video-connector";
label = "tv";

port {
Expand Down

0 comments on commit 32797b3

Please sign in to comment.