Skip to content

Commit

Permalink
ocxl: read_pasid never returns an error, so make it void
Browse files Browse the repository at this point in the history
No need for a return value in read_pasid as it only returns 0.

Signed-off-by: Alastair D'Silva <alastair@d-silva.org>
Reviewed-by: Greg Kurz <groug@kaod.org>
Acked-by: Frederic Barrat <fbarrat@linux.ibm.com>
Acked-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
  • Loading branch information
Alastair D'Silva authored and Michael Ellerman committed May 2, 2019
1 parent 9c4ae06 commit 3294149
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions drivers/misc/ocxl/config.c
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ static int find_dvsec_afu_ctrl(struct pci_dev *dev, u8 afu_idx)
return 0;
}

static int read_pasid(struct pci_dev *dev, struct ocxl_fn_config *fn)
static void read_pasid(struct pci_dev *dev, struct ocxl_fn_config *fn)
{
u16 val;
int pos;
Expand All @@ -89,7 +89,6 @@ static int read_pasid(struct pci_dev *dev, struct ocxl_fn_config *fn)
out:
dev_dbg(&dev->dev, "PASID capability:\n");
dev_dbg(&dev->dev, " Max PASID log = %d\n", fn->max_pasid_log);
return 0;
}

static int read_dvsec_tl(struct pci_dev *dev, struct ocxl_fn_config *fn)
Expand Down Expand Up @@ -205,11 +204,7 @@ int ocxl_config_read_function(struct pci_dev *dev, struct ocxl_fn_config *fn)
{
int rc;

rc = read_pasid(dev, fn);
if (rc) {
dev_err(&dev->dev, "Invalid PASID configuration: %d\n", rc);
return -ENODEV;
}
read_pasid(dev, fn);

rc = read_dvsec_tl(dev, fn);
if (rc) {
Expand Down

0 comments on commit 3294149

Please sign in to comment.