Skip to content

Commit

Permalink
lockdep: rename map_[acquire|release]() => lock_map_[acquire|release]()
Browse files Browse the repository at this point in the history
the names were too generic:

 drivers/uio/uio.c:87: error: expected identifier or '(' before 'do'
 drivers/uio/uio.c:87: error: expected identifier or '(' before 'while'
 drivers/uio/uio.c:113: error: 'map_release' undeclared here (not in a function)

Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Ingo Molnar committed Aug 11, 2008
1 parent 8bfe029 commit 3295f0e
Show file tree
Hide file tree
Showing 4 changed files with 21 additions and 21 deletions.
4 changes: 2 additions & 2 deletions fs/jbd/transaction.c
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ handle_t *journal_start(journal_t *journal, int nblocks)
goto out;
}

map_acquire(&handle->h_lockdep_map);
lock_map_acquire(&handle->h_lockdep_map);

out:
return handle;
Expand Down Expand Up @@ -1448,7 +1448,7 @@ int journal_stop(handle_t *handle)
spin_unlock(&journal->j_state_lock);
}

map_release(&handle->h_lockdep_map);
lock_map_release(&handle->h_lockdep_map);

jbd_free_handle(handle);
return err;
Expand Down
4 changes: 2 additions & 2 deletions fs/jbd2/transaction.c
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ handle_t *jbd2_journal_start(journal_t *journal, int nblocks)
goto out;
}

map_acquire(&handle->h_lockdep_map);
lock_map_acquire(&handle->h_lockdep_map);
out:
return handle;
}
Expand Down Expand Up @@ -1279,7 +1279,7 @@ int jbd2_journal_stop(handle_t *handle)
spin_unlock(&journal->j_state_lock);
}

map_release(&handle->h_lockdep_map);
lock_map_release(&handle->h_lockdep_map);

jbd2_free_handle(handle);
return err;
Expand Down
10 changes: 5 additions & 5 deletions include/linux/lockdep.h
Original file line number Diff line number Diff line change
Expand Up @@ -465,14 +465,14 @@ static inline void print_irqtrace_events(struct task_struct *curr)

#ifdef CONFIG_DEBUG_LOCK_ALLOC
# ifdef CONFIG_PROVE_LOCKING
# define map_acquire(l) lock_acquire(l, 0, 0, 0, 2, NULL, _THIS_IP_)
# define lock_map_acquire(l) lock_acquire(l, 0, 0, 0, 2, NULL, _THIS_IP_)
# else
# define map_acquire(l) lock_acquire(l, 0, 0, 0, 1, NULL, _THIS_IP_)
# define lock_map_acquire(l) lock_acquire(l, 0, 0, 0, 1, NULL, _THIS_IP_)
# endif
# define map_release(l) lock_release(l, 1, _THIS_IP_)
# define lock_map_release(l) lock_release(l, 1, _THIS_IP_)
#else
# define map_acquire(l) do { } while (0)
# define map_release(l) do { } while (0)
# define lock_map_acquire(l) do { } while (0)
# define lock_map_release(l) do { } while (0)
#endif

#endif /* __LINUX_LOCKDEP_H */
24 changes: 12 additions & 12 deletions kernel/workqueue.c
Original file line number Diff line number Diff line change
Expand Up @@ -290,11 +290,11 @@ static void run_workqueue(struct cpu_workqueue_struct *cwq)

BUG_ON(get_wq_data(work) != cwq);
work_clear_pending(work);
map_acquire(&cwq->wq->lockdep_map);
map_acquire(&lockdep_map);
lock_map_acquire(&cwq->wq->lockdep_map);
lock_map_acquire(&lockdep_map);
f(work);
map_release(&lockdep_map);
map_release(&cwq->wq->lockdep_map);
lock_map_release(&lockdep_map);
lock_map_release(&cwq->wq->lockdep_map);

if (unlikely(in_atomic() || lockdep_depth(current) > 0)) {
printk(KERN_ERR "BUG: workqueue leaked lock or atomic: "
Expand Down Expand Up @@ -413,8 +413,8 @@ void flush_workqueue(struct workqueue_struct *wq)
int cpu;

might_sleep();
map_acquire(&wq->lockdep_map);
map_release(&wq->lockdep_map);
lock_map_acquire(&wq->lockdep_map);
lock_map_release(&wq->lockdep_map);
for_each_cpu_mask_nr(cpu, *cpu_map)
flush_cpu_workqueue(per_cpu_ptr(wq->cpu_wq, cpu));
}
Expand All @@ -441,8 +441,8 @@ int flush_work(struct work_struct *work)
if (!cwq)
return 0;

map_acquire(&cwq->wq->lockdep_map);
map_release(&cwq->wq->lockdep_map);
lock_map_acquire(&cwq->wq->lockdep_map);
lock_map_release(&cwq->wq->lockdep_map);

prev = NULL;
spin_lock_irq(&cwq->lock);
Expand Down Expand Up @@ -536,8 +536,8 @@ static void wait_on_work(struct work_struct *work)

might_sleep();

map_acquire(&work->lockdep_map);
map_release(&work->lockdep_map);
lock_map_acquire(&work->lockdep_map);
lock_map_release(&work->lockdep_map);

cwq = get_wq_data(work);
if (!cwq)
Expand Down Expand Up @@ -861,8 +861,8 @@ static void cleanup_workqueue_thread(struct cpu_workqueue_struct *cwq)
if (cwq->thread == NULL)
return;

map_acquire(&cwq->wq->lockdep_map);
map_release(&cwq->wq->lockdep_map);
lock_map_acquire(&cwq->wq->lockdep_map);
lock_map_release(&cwq->wq->lockdep_map);

flush_cpu_workqueue(cwq);
/*
Expand Down

0 comments on commit 3295f0e

Please sign in to comment.