Skip to content

Commit

Permalink
PCI: Use consistent put_user() pointer types
Browse files Browse the repository at this point in the history
We used u8, u16, and u32 for get_user() pointer types, but "unsigned char",
"unsigned short", and "unsigned int" for put_user().

Use u8, u16, and u32 for put_user() for consistency.  No functional change
intended.

Link: https://lore.kernel.org/r/20230824193712.542167-6-helgaas@kernel.org
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
  • Loading branch information
Bjorn Helgaas committed Aug 25, 2023
1 parent 6200857 commit 32e2a3f
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions drivers/pci/syscall.c
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,13 @@ SYSCALL_DEFINE5(pciconfig_read, unsigned long, bus, unsigned long, dfn,

switch (len) {
case 1:
err = put_user(byte, (unsigned char __user *)buf);
err = put_user(byte, (u8 __user *)buf);
break;
case 2:
err = put_user(word, (unsigned short __user *)buf);
err = put_user(word, (u16 __user *)buf);
break;
case 4:
err = put_user(dword, (unsigned int __user *)buf);
err = put_user(dword, (u32 __user *)buf);
break;
}
pci_dev_put(dev);
Expand All @@ -70,13 +70,13 @@ SYSCALL_DEFINE5(pciconfig_read, unsigned long, bus, unsigned long, dfn,
they get instead of a machine check on x86. */
switch (len) {
case 1:
put_user(-1, (unsigned char __user *)buf);
put_user(-1, (u8 __user *)buf);
break;
case 2:
put_user(-1, (unsigned short __user *)buf);
put_user(-1, (u16 __user *)buf);
break;
case 4:
put_user(-1, (unsigned int __user *)buf);
put_user(-1, (u32 __user *)buf);
break;
}
pci_dev_put(dev);
Expand Down

0 comments on commit 32e2a3f

Please sign in to comment.