Skip to content

Commit

Permalink
scsi: aic94xx: Add missing check for dma_map_single()
Browse files Browse the repository at this point in the history
Add check for dma_map_single() and return error if it fails in order to
avoid invalid DMA address.

Fixes: 2908d77 ("[SCSI] aic94xx: new driver")
Link: https://lore.kernel.org/r/20230128110832.6792-1-jiasheng@iscas.ac.cn
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Reviewed-by: Jason Yan <yanaijie@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
  • Loading branch information
Jiasheng Jiang authored and Martin K. Petersen committed Feb 9, 2023
1 parent ead8212 commit 32fe452
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions drivers/scsi/aic94xx/aic94xx_task.c
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,9 @@ static int asd_map_scatterlist(struct sas_task *task,
dma_addr_t dma = dma_map_single(&asd_ha->pcidev->dev, p,
task->total_xfer_len,
task->data_dir);
if (dma_mapping_error(&asd_ha->pcidev->dev, dma))
return -ENOMEM;

sg_arr[0].bus_addr = cpu_to_le64((u64)dma);
sg_arr[0].size = cpu_to_le32(task->total_xfer_len);
sg_arr[0].flags |= ASD_SG_EL_LIST_EOL;
Expand Down

0 comments on commit 32fe452

Please sign in to comment.