Skip to content

Commit

Permalink
xen/spinlock: Don't setup xen spinlock IPI kicker if disabled.
Browse files Browse the repository at this point in the history
There is no need to setup this kicker IPI if we are never going
to use the paravirtualized ticketlock mechanism.

Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Reviewed-by: David Vrabel <david.vrabel@citrix.com>
  • Loading branch information
Konrad Rzeszutek Wilk committed Sep 9, 2013
1 parent 26a7999 commit 3310bbe
Showing 1 changed file with 10 additions and 1 deletion.
11 changes: 10 additions & 1 deletion arch/x86/xen/spinlock.c
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ static DEFINE_PER_CPU(char *, irq_name);
static DEFINE_PER_CPU(struct xen_lock_waiting, lock_waiting);
static cpumask_t waiting_cpus;

static bool xen_pvspin __initdata = true;
static void xen_lock_spinning(struct arch_spinlock *lock, __ticket_t want)
{
int irq = __this_cpu_read(lock_kicker_irq);
Expand Down Expand Up @@ -223,6 +224,9 @@ void xen_init_lock_cpu(int cpu)
int irq;
char *name;

if (!xen_pvspin)
return;

WARN(per_cpu(lock_kicker_irq, cpu) >= 0, "spinlock on CPU%d exists on IRQ%d!\n",
cpu, per_cpu(lock_kicker_irq, cpu));

Expand Down Expand Up @@ -259,13 +263,15 @@ void xen_uninit_lock_cpu(int cpu)
if (xen_hvm_domain())
return;

if (!xen_pvspin)
return;

unbind_from_irqhandler(per_cpu(lock_kicker_irq, cpu), NULL);
per_cpu(lock_kicker_irq, cpu) = -1;
kfree(per_cpu(irq_name, cpu));
per_cpu(irq_name, cpu) = NULL;
}

static bool xen_pvspin __initdata = true;

void __init xen_init_spinlocks(void)
{
Expand Down Expand Up @@ -305,6 +311,9 @@ static int __init xen_spinlock_debugfs(void)
if (d_xen == NULL)
return -ENOMEM;

if (!xen_pvspin)
return 0;

d_spin_debug = debugfs_create_dir("spinlocks", d_xen);

debugfs_create_u8("zero_stats", 0644, d_spin_debug, &zero_stats);
Expand Down

0 comments on commit 3310bbe

Please sign in to comment.