Skip to content

Commit

Permalink
net: Fix ks8851 snl NULL pointer dereference Oops
Browse files Browse the repository at this point in the history
This fixes the NULL pointer dereference Oops in the ks8851 snl network
driver during transmission.  All socket buffers from the queue are
processed inside the loop, but new workqueues have been scheduled to
run.

Signed-off-by: Tristram Ha <Tristram.Ha@micrel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Tristram Ha authored and David S. Miller committed Dec 4, 2009
1 parent fc4a748 commit 3320eae
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/net/ks8851.c
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* drivers/net/ks8651.c
/* drivers/net/ks8851.c
*
* Copyright 2009 Simtec Electronics
* http://www.simtec.co.uk/
Expand Down Expand Up @@ -714,7 +714,7 @@ static void ks8851_tx_work(struct work_struct *work)
{
struct ks8851_net *ks = container_of(work, struct ks8851_net, tx_work);
struct sk_buff *txb;
bool last = false;
bool last = skb_queue_empty(&ks->txq);

mutex_lock(&ks->lock);

Expand Down

0 comments on commit 3320eae

Please sign in to comment.