Skip to content

Commit

Permalink
drm/amd/powerplay: remove uncessary extra gfxoff control call
Browse files Browse the repository at this point in the history
Gfxoff is already enabled in amdgpu_device_ip_set_powergating_state.
So, no need to enable it again in pp_late_init.

Signed-off-by: Evan Quan <evan.quan@amd.com>
Reviewed-by: Huang Rui <ray.huang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
  • Loading branch information
Evan Quan authored and Alex Deucher committed Jun 13, 2018
1 parent cb5ed37 commit 333c8d3
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions drivers/gpu/drm/amd/powerplay/amd_powerplay.c
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,6 @@ static int pp_late_init(void *handle)
{
struct amdgpu_device *adev = handle;
struct pp_hwmgr *hwmgr = adev->powerplay.pp_handle;
int ret;

if (hwmgr && hwmgr->pm_en) {
mutex_lock(&hwmgr->smu_lock);
Expand All @@ -191,14 +190,6 @@ static int pp_late_init(void *handle)
if (adev->pm.smu_prv_buffer_size != 0)
pp_reserve_vram_for_smu(adev);

if (hwmgr && hwmgr->hwmgr_func &&
hwmgr->hwmgr_func->gfx_off_control &&
(hwmgr->feature_mask & PP_GFXOFF_MASK)) {
ret = hwmgr->hwmgr_func->gfx_off_control(hwmgr, true);
if (ret)
pr_err("gfx off enabling failed!\n");
}

return 0;
}

Expand Down

0 comments on commit 333c8d3

Please sign in to comment.