Skip to content

Commit

Permalink
Input: mousedev - rename mixdev_open to opened_by_mixdev
Browse files Browse the repository at this point in the history
Do the rename to make the logic more clear and also change it to bool
while at it.

Reviewed-by: David Herrmann <dh.herrmann@googlemail.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
  • Loading branch information
Dmitry Torokhov committed Oct 8, 2012
1 parent 1c74585 commit 3376b8b
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions drivers/input/mousedev.c
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ struct mousedev {
bool exist;

struct list_head mixdev_node;
int mixdev_open;
bool opened_by_mixdev;

struct mousedev_hw_data packet;
unsigned int pkt_count;
Expand Down Expand Up @@ -469,11 +469,11 @@ static void mixdev_open_devices(void)
return;

list_for_each_entry(mousedev, &mousedev_mix_list, mixdev_node) {
if (!mousedev->mixdev_open) {
if (!mousedev->opened_by_mixdev) {
if (mousedev_open_device(mousedev))
continue;

mousedev->mixdev_open = 1;
mousedev->opened_by_mixdev = true;
}
}
}
Expand All @@ -491,8 +491,8 @@ static void mixdev_close_devices(void)
return;

list_for_each_entry(mousedev, &mousedev_mix_list, mixdev_node) {
if (mousedev->mixdev_open) {
mousedev->mixdev_open = 0;
if (mousedev->opened_by_mixdev) {
mousedev->opened_by_mixdev = false;
mousedev_close_device(mousedev);
}
}
Expand Down Expand Up @@ -935,7 +935,7 @@ static int mixdev_add_device(struct mousedev *mousedev)
if (retval)
goto out;

mousedev->mixdev_open = 1;
mousedev->opened_by_mixdev = true;
}

get_device(&mousedev->dev);
Expand All @@ -950,8 +950,8 @@ static void mixdev_remove_device(struct mousedev *mousedev)
{
mutex_lock(&mousedev_mix->mutex);

if (mousedev->mixdev_open) {
mousedev->mixdev_open = 0;
if (mousedev->opened_by_mixdev) {
mousedev->opened_by_mixdev = false;
mousedev_close_device(mousedev);
}

Expand Down

0 comments on commit 3376b8b

Please sign in to comment.