Skip to content

Commit

Permalink
usb: typec: ucsi: Fix the notification bit offsets
Browse files Browse the repository at this point in the history
The bit offsets for the Set Notification Enable command were
not considering the reserved bits in the middle.

Fixes: 470ce43 ("usb: typec: ucsi: Remove struct ucsi_control")
Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://lore.kernel.org/r/20200108131347.43217-2-heikki.krogerus@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Heikki Krogerus authored and Greg Kroah-Hartman committed Jan 8, 2020
1 parent 2548288 commit 33786a2
Showing 1 changed file with 9 additions and 9 deletions.
18 changes: 9 additions & 9 deletions drivers/usb/typec/ucsi/ucsi.h
Original file line number Diff line number Diff line change
Expand Up @@ -94,15 +94,15 @@ void ucsi_connector_change(struct ucsi *ucsi, u8 num);
#define UCSI_ENABLE_NTFY_CMD_COMPLETE BIT(16)
#define UCSI_ENABLE_NTFY_EXT_PWR_SRC_CHANGE BIT(17)
#define UCSI_ENABLE_NTFY_PWR_OPMODE_CHANGE BIT(18)
#define UCSI_ENABLE_NTFY_CAP_CHANGE BIT(19)
#define UCSI_ENABLE_NTFY_PWR_LEVEL_CHANGE BIT(20)
#define UCSI_ENABLE_NTFY_PD_RESET_COMPLETE BIT(21)
#define UCSI_ENABLE_NTFY_CAM_CHANGE BIT(22)
#define UCSI_ENABLE_NTFY_BAT_STATUS_CHANGE BIT(23)
#define UCSI_ENABLE_NTFY_PARTNER_CHANGE BIT(24)
#define UCSI_ENABLE_NTFY_PWR_DIR_CHANGE BIT(25)
#define UCSI_ENABLE_NTFY_CONNECTOR_CHANGE BIT(26)
#define UCSI_ENABLE_NTFY_ERROR BIT(27)
#define UCSI_ENABLE_NTFY_CAP_CHANGE BIT(21)
#define UCSI_ENABLE_NTFY_PWR_LEVEL_CHANGE BIT(22)
#define UCSI_ENABLE_NTFY_PD_RESET_COMPLETE BIT(23)
#define UCSI_ENABLE_NTFY_CAM_CHANGE BIT(24)
#define UCSI_ENABLE_NTFY_BAT_STATUS_CHANGE BIT(25)
#define UCSI_ENABLE_NTFY_PARTNER_CHANGE BIT(27)
#define UCSI_ENABLE_NTFY_PWR_DIR_CHANGE BIT(28)
#define UCSI_ENABLE_NTFY_CONNECTOR_CHANGE BIT(30)
#define UCSI_ENABLE_NTFY_ERROR BIT(31)
#define UCSI_ENABLE_NTFY_ALL 0xdbe70000

/* SET_UOR command bits */
Expand Down

0 comments on commit 33786a2

Please sign in to comment.