Skip to content

Commit

Permalink
thunderbolt: debugfs: Show all accessible dwords
Browse files Browse the repository at this point in the history
Currently, when first failure occurs while reading of the block,
we stop reading the block and jump to the next capability.
This doesn't cover the case of block with "holes" of inaccessible
dwords, followed by accessible dwords.
This patch address this problem.
In case of failure while reading the complete block in one transaction,
(because of one or more dwords is inaccessible), we read the remaining
dwords of the block dword-by-dword, one dword per transaction,
till the end of the block.
By doing this, we handle the case of block with "holes" of inaccessible
dwords, followed by accessible dwords. The accessible dwords are shown
with the fields: <offset> <relative_offset> <cap_id> <vs_cap_id> <value>
E.g.:
0x01eb  236 0x05 0x06 0x0000d166
While the inaccesible dwords are shown as: <offset> <not accessible>
E.g.:
0x01ed <not accessible>

Signed-off-by: Gil Fine <gil.fine@intel.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
  • Loading branch information
Gil Fine authored and Mika Westerberg committed Mar 12, 2021
1 parent d59b8fa commit 3382665
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions drivers/thunderbolt/debugfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -265,10 +265,8 @@ static void cap_show_by_dw(struct seq_file *s, struct tb_switch *sw,
else
ret = tb_sw_read(sw, &data, TB_CFG_SWITCH, cap + offset + i, 1);
if (ret) {
seq_printf(s, "0x%04x <not accessible>\n", cap + offset);
if (dwords - i > 1)
seq_printf(s, "0x%04x ...\n", cap + offset + 1);
return;
seq_printf(s, "0x%04x <not accessible>\n", cap + offset + i);
continue;
}

seq_printf(s, "0x%04x %4d 0x%02x 0x%02x 0x%08x\n", cap + offset + i,
Expand All @@ -292,7 +290,7 @@ static void cap_show(struct seq_file *s, struct tb_switch *sw,
else
ret = tb_sw_read(sw, data, TB_CFG_SWITCH, cap + offset, dwords);
if (ret) {
cap_show_by_dw(s, sw, port, cap, offset, cap_id, vsec_id, dwords);
cap_show_by_dw(s, sw, port, cap, offset, cap_id, vsec_id, length);
return;
}

Expand Down

0 comments on commit 3382665

Please sign in to comment.