Skip to content

Commit

Permalink
PCI: Avoid slot reset if bridge itself is broken
Browse files Browse the repository at this point in the history
When checking to see if a PCI slot can safely be reset, we previously
checked to see if any of the children had their PCI_DEV_FLAGS_NO_BUS_RESET
flag set.

Some PCIe root port bridges do not behave well after a slot reset, and may
cause the device in the slot to become unusable.

Add a check for PCI_DEV_FLAGS_NO_BUS_RESET being set in the bridge device
to prevent the slot from being reset.

Signed-off-by: Jan Glauber <jglauber@cavium.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Alex Williamson <alex.williamson@redhat.com>
  • Loading branch information
Jan Glauber authored and Bjorn Helgaas committed Oct 11, 2017
1 parent 3570277 commit 33ba90a
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions drivers/pci/pci.c
Original file line number Diff line number Diff line change
Expand Up @@ -4424,6 +4424,10 @@ static bool pci_slot_resetable(struct pci_slot *slot)
{
struct pci_dev *dev;

if (slot->bus->self &&
(slot->bus->self->dev_flags & PCI_DEV_FLAGS_NO_BUS_RESET))
return false;

list_for_each_entry(dev, &slot->bus->devices, bus_list) {
if (!dev->slot || dev->slot != slot)
continue;
Expand Down

0 comments on commit 33ba90a

Please sign in to comment.