Skip to content

Commit

Permalink
fanotify: remove outgoing function checks in fanotify.h
Browse files Browse the repository at this point in the history
A number of validity checks on outgoing data are done in static inlines but
are only used in one place.  Instead just do them where they are used for
readability.

Signed-off-by: Andreas Gruenbacher <agruen@suse.de>
Signed-off-by: Eric Paris <eparis@redhat.com>
  • Loading branch information
Andreas Gruenbacher authored and Eric Paris committed Jul 28, 2010
1 parent 88380fe commit 33d3dff
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 16 deletions.
3 changes: 1 addition & 2 deletions fs/notify/fanotify/fanotify.c
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
#include <linux/fanotify.h>
#include <linux/fdtable.h>
#include <linux/fsnotify_backend.h>
#include <linux/init.h>
#include <linux/kernel.h> /* UINT_MAX */
#include <linux/mount.h>
#include <linux/types.h>

#include "fanotify.h"

static bool should_merge(struct fsnotify_event *old, struct fsnotify_event *new)
{
pr_debug("%s: old=%p new=%p\n", __func__, old, new);
Expand Down
12 changes: 0 additions & 12 deletions fs/notify/fanotify/fanotify.h

This file was deleted.

5 changes: 3 additions & 2 deletions fs/notify/fanotify/fanotify_user.c
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#include <linux/fanotify.h>
#include <linux/fcntl.h>
#include <linux/file.h>
#include <linux/fs.h>
Expand All @@ -14,7 +15,7 @@

#include <asm/ioctls.h>

#include "fanotify.h"
extern const struct fsnotify_ops fanotify_fsnotify_ops;

static struct kmem_cache *fanotify_mark_cache __read_mostly;

Expand Down Expand Up @@ -102,7 +103,7 @@ static ssize_t fill_event_metadata(struct fsnotify_group *group,

metadata->event_len = FAN_EVENT_METADATA_LEN;
metadata->vers = FANOTIFY_METADATA_VERSION;
metadata->mask = fanotify_outgoing_mask(event->mask);
metadata->mask = event->mask & FAN_ALL_OUTGOING_EVENTS;
metadata->pid = pid_vnr(event->tgid);
metadata->fd = create_fd(group, event);

Expand Down

0 comments on commit 33d3dff

Please sign in to comment.