Skip to content

Commit

Permalink
powerpc/xive: Rename the 'cpus' debugfs file to 'ipis'
Browse files Browse the repository at this point in the history
and remove the EQ entries output which is not very useful since only
the next two events of the queue are taken into account. We will
improve the dump of the EQ in the next patches.

Signed-off-by: Cédric Le Goater <clg@kaod.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20211105102636.1016378-7-clg@kaod.org
  • Loading branch information
Cédric Le Goater authored and Michael Ellerman committed Nov 25, 2021
1 parent baed14d commit 33e1d4a
Showing 1 changed file with 7 additions and 20 deletions.
27 changes: 7 additions & 20 deletions arch/powerpc/sysdev/xive/common.c
Original file line number Diff line number Diff line change
Expand Up @@ -1703,11 +1703,11 @@ static int __init xive_off(char *arg)
__setup("xive=off", xive_off);

#ifdef CONFIG_DEBUG_FS
static void xive_debug_show_cpu(struct seq_file *m, int cpu)
static void xive_debug_show_ipi(struct seq_file *m, int cpu)
{
struct xive_cpu *xc = per_cpu(xive_cpu, cpu);

seq_printf(m, "CPU %d:", cpu);
seq_printf(m, "CPU %d: ", cpu);
if (xc) {
seq_printf(m, "pp=%02x CPPR=%02x ", xc->pending_prio, xc->cppr);

Expand All @@ -1719,19 +1719,6 @@ static void xive_debug_show_cpu(struct seq_file *m, int cpu)
seq_printf(m, "IPI=0x%08x %s", xc->hw_ipi, buffer);
}
#endif
{
struct xive_q *q = &xc->queue[xive_irq_priority];
u32 i0, i1, idx;

if (q->qpage) {
idx = q->idx;
i0 = be32_to_cpup(q->qpage + idx);
idx = (idx + 1) & q->msk;
i1 = be32_to_cpup(q->qpage + idx);
seq_printf(m, "EQ idx=%d T=%d %08x %08x ...",
q->idx, q->toggle, i0, i1);
}
}
}
seq_puts(m, "\n");
}
Expand Down Expand Up @@ -1774,18 +1761,18 @@ static int xive_irq_debug_show(struct seq_file *m, void *private)
}
DEFINE_SHOW_ATTRIBUTE(xive_irq_debug);

static int xive_cpu_debug_show(struct seq_file *m, void *private)
static int xive_ipi_debug_show(struct seq_file *m, void *private)
{
int cpu;

if (xive_ops->debug_show)
xive_ops->debug_show(m, private);

for_each_possible_cpu(cpu)
xive_debug_show_cpu(m, cpu);
xive_debug_show_ipi(m, cpu);
return 0;
}
DEFINE_SHOW_ATTRIBUTE(xive_cpu_debug);
DEFINE_SHOW_ATTRIBUTE(xive_ipi_debug);

static void xive_core_debugfs_create(void)
{
Expand All @@ -1795,8 +1782,8 @@ static void xive_core_debugfs_create(void)
if (IS_ERR(xive_dir))
return;

debugfs_create_file("cpus", 0400, xive_dir,
NULL, &xive_cpu_debug_fops);
debugfs_create_file("ipis", 0400, xive_dir,
NULL, &xive_ipi_debug_fops);
debugfs_create_file("interrupts", 0400, xive_dir,
NULL, &xive_irq_debug_fops);
}
Expand Down

0 comments on commit 33e1d4a

Please sign in to comment.