Skip to content

Commit

Permalink
net: ethernet: don't set phylib state CHANGELINK in drivers
Browse files Browse the repository at this point in the history
After phy_start() phylib takes care of all needed actions, including
aneg settings and checking link state. There's no need to set state
PHY_CHANGELINK in drivers.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Heiner Kallweit authored and David S. Miller committed Dec 19, 2018
1 parent 624b66f commit 33f18c9
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
5 changes: 1 addition & 4 deletions drivers/net/ethernet/amd/au1000_eth.c
Original file line number Diff line number Diff line change
Expand Up @@ -940,11 +940,8 @@ static int au1000_open(struct net_device *dev)
return retval;
}

if (dev->phydev) {
/* cause the PHY state machine to schedule a link state check */
dev->phydev->state = PHY_CHANGELINK;
if (dev->phydev)
phy_start(dev->phydev);
}

netif_start_queue(dev);

Expand Down
1 change: 0 additions & 1 deletion drivers/net/ethernet/ti/cpmac.c
Original file line number Diff line number Diff line change
Expand Up @@ -991,7 +991,6 @@ static int cpmac_open(struct net_device *dev)
cpmac_hw_start(dev);

napi_enable(&priv->napi);
dev->phydev->state = PHY_CHANGELINK;
phy_start(dev->phydev);

return 0;
Expand Down

0 comments on commit 33f18c9

Please sign in to comment.