Skip to content

Commit

Permalink
efi: sysfb_efi: remove unnecessary <asm/efi.h> include
Browse files Browse the repository at this point in the history
Nothing defined in the header is used by drivers/firmware/efi/sysfb_efi.c
but also, including it can lead to build errors when built on arches that
don't have an asm/efi.h header file.

This can happen for example if a driver that is built when COMPILE_TEST is
enabled selects the SYSFB symbol, e.g. on powerpc with allyesconfig:

drivers/firmware/efi/sysfb_efi.c:29:10: fatal error: asm/efi.h: No such file or directory
   29 | #include <asm/efi.h>
      |          ^~~~~~~~~~~

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
  • Loading branch information
Javier Martinez Canillas authored and Ard Biesheuvel committed Jun 21, 2022
1 parent f2906aa commit 34705a5
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions drivers/firmware/efi/sysfb_efi.c
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@
#include <linux/sysfb.h>
#include <video/vga.h>

#include <asm/efi.h>

enum {
OVERRIDE_NONE = 0x0,
OVERRIDE_BASE = 0x1,
Expand Down

0 comments on commit 34705a5

Please sign in to comment.