Skip to content

Commit

Permalink
Staging: iio: accel: sca3000: Fixed NULL comparison style
Browse files Browse the repository at this point in the history
The variable u8 **rx_p, is a pointer-to-pointer and hence the check
should
be "if (!*rx_p)" and not "if (!rx_p)".
In the earlier version, checkpatch.pl gave the following check, which
was incorrect:
CHECK: Comparison to NULL could be written "!rx_p"
+       if (*rx_p == NULL) {

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
  • Loading branch information
Bhaktipriya Shridhar authored and Jonathan Cameron committed Dec 19, 2015
1 parent 6e17c98 commit 34708a0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/staging/iio/accel/sca3000_ring.c
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ static int sca3000_read_data(struct sca3000_state *st,
}
};
*rx_p = kmalloc(len, GFP_KERNEL);
if (*rx_p == NULL) {
if (!*rx_p) {
ret = -ENOMEM;
goto error_ret;
}
Expand Down

0 comments on commit 34708a0

Please sign in to comment.