Skip to content

Commit

Permalink
spi: a3700: Remove endianness swapping for full-duplex transfers
Browse files Browse the repository at this point in the history
Fixes the following sparse warnings :
line 767: warning: incorrect type in assignment (different base types)
line 767:    expected unsigned int [unsigned] [assigned] [usertype] val_out
line 767:    got restricted __le32 [usertype] <noident>
line 776: warning: cast to restricted __le32

This takes advantage of readl/writel to do the endianness reordering,
and removes an extra variable in the function.

Fixes: f68a7dc ("spi: a3700: Add full-duplex support")
Signed-off-by: Maxime Chevallier <maxime.chevallier@smile.fr>
Reviewed-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Maxime Chevallier authored and Mark Brown committed Jan 24, 2018
1 parent 162f8de commit 34b1fca
Showing 1 changed file with 6 additions and 7 deletions.
13 changes: 6 additions & 7 deletions drivers/spi/spi-armada-3700.c
Original file line number Diff line number Diff line change
Expand Up @@ -739,7 +739,7 @@ static int a3700_spi_transfer_one_full_duplex(struct spi_master *master,
struct spi_transfer *xfer)
{
struct a3700_spi *a3700_spi = spi_master_get_devdata(master);
u32 val_in, val_out;
u32 val;

/* Disable FIFO mode */
a3700_spi_fifo_mode_set(a3700_spi, false);
Expand All @@ -753,21 +753,20 @@ static int a3700_spi_transfer_one_full_duplex(struct spi_master *master,
a3700_spi_bytelen_set(a3700_spi, 1);

if (a3700_spi->byte_len == 1)
val_out = *a3700_spi->tx_buf;
val = *a3700_spi->tx_buf;
else
val_out = cpu_to_le32(*(u32 *)a3700_spi->tx_buf);
val = *(u32 *)a3700_spi->tx_buf;

spireg_write(a3700_spi, A3700_SPI_DATA_OUT_REG, val_out);
spireg_write(a3700_spi, A3700_SPI_DATA_OUT_REG, val);

/* Wait for all the data to be shifted in / out */
while (!(spireg_read(a3700_spi, A3700_SPI_IF_CTRL_REG) &
A3700_SPI_XFER_DONE))
cpu_relax();

val_in = le32_to_cpu(spireg_read(a3700_spi,
A3700_SPI_DATA_IN_REG));
val = spireg_read(a3700_spi, A3700_SPI_DATA_IN_REG);

memcpy(a3700_spi->rx_buf, &val_in, a3700_spi->byte_len);
memcpy(a3700_spi->rx_buf, &val, a3700_spi->byte_len);

a3700_spi->buf_len -= a3700_spi->byte_len;
a3700_spi->tx_buf += a3700_spi->byte_len;
Expand Down

0 comments on commit 34b1fca

Please sign in to comment.