Skip to content

Commit

Permalink
serial: xuartps: remove unnecessary register write
Browse files Browse the repository at this point in the history
This writel writes the exact same value as the previous writel and is
thus unnecessary. It accidentally became unnecessary in e3538c3
("tty: xuartps: Beautify read-modify writes"), but the new behaviour is
now expected.

Link: https://www.spinics.net/lists/linux-serial/msg23168.html
Signed-off-by: Helmut Grohne <h.grohne@intenta.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Helmut Grohne authored and Greg Kroah-Hartman committed Jun 28, 2018
1 parent de4ed39 commit 34b6a3a
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions drivers/tty/serial/xilinx_uartps.c
Original file line number Diff line number Diff line change
Expand Up @@ -1203,8 +1203,6 @@ static void cdns_uart_console_write(struct console *co, const char *s,
CDNS_UART_SR_TXEMPTY)
cpu_relax();

writel(ctrl, port->membase + CDNS_UART_CR);

/* restore interrupt state */
writel(imr, port->membase + CDNS_UART_IER);

Expand Down

0 comments on commit 34b6a3a

Please sign in to comment.